Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate NavigationToolbar2.dynamic_update. #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2017
Merged

Deprecate NavigationToolbar2.dynamic_update. #8697

merged 1 commit into from
Jun 2, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 1, 2017

The method has been described as "legacy" in comments since 2005
(68eb00a).

PR Summary

PR Checklist

  • NA Has Pytest style unit tests
  • NA Code is PEP 8 compliant
  • NA New features are documented, with examples if plot related
  • NA Documentation is sphinx and numpydoc compliant
  • NA Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the deprecate-dynamic_update branch from eb86cca to bd92ddb Compare June 1, 2017 04:42
@anntzer
Copy link
Contributor Author

anntzer commented Jun 1, 2017

(appveyor fail is clearly spurious)

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jun 2, 2017
QuLogic
QuLogic reviewed Jun 2, 2017
View reviewed changes
doc/api/api_changes/2017-05-31-AL_dynamic_update.rst Outdated
NavigationToolbar2.dynamic_update is deprecated
```````````````````````````````````````````````

Use ``canvas.draw_idle`` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FigureCanvas.draw_idle to link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@anntzer
Deprecate NavigationToolbar2.dynamic_update.
7f0e27c 
The method has been described as "legacy" in comments since 2005
(68eb00a).
@anntzer anntzer force-pushed the deprecate-dynamic_update branch from bd92ddb to 7f0e27c Compare June 2, 2017 04:18
@dstansby dstansby merged commit eb6e422 into matplotlib:master Jun 2, 2017
@anntzer anntzer deleted the deprecate-dynamic_update branch June 2, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @QuLogic @dstansby