Fixed bug caused by wrong scoping #8724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug related to potentially wrong variable scope where the inner `this` of a function is used instead of the `this` of the outer scope.
|
What bug is this fixing? It looks like figures not being closed properly when they are removed from the DOM? |
tacaswell
approved these changes
Jun 6, 2017
|
attn @SylvainCorlay not sure if this is part of the code that migrated to ipympl |
|
I think the web backend got reverted, so maybe this PR is no longer needed? |
|
Closing in favor of #9108 which is this commit chery-picked on top of current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug related to potentially wrong variable scope where the inner
thisof a function is used instead of thethisof the outer scope.