Allow users to control the fill for AnchoredSizeBar #8835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Jul 4, 2017
|
To distinguish between the bar and the fill for the whole size bar, including the label and frame. |
|
This is an almost identical change to #8829 50/50 on Should definitely pull the whats_new from #8829 and think about the variable default behavior from #8829 (comment) |
|
Fair enough. @magnunor I'm going to go ahead and implement the suggestion to make the default filling behavior depend on |
|
Closing and reopening to trigger another test run. |
|
Sounds good! I'll close my pull request. |
4 tasks
|
Thanks @ngoldbaum and @magnunor ! Two PRs to do the same thing clearly shows there is a need :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently it's only possible to control the
fillproperty for theRectanglepatch created by the AnchoredSizeBar by doing something like:This is very non-obvious and as far as I can tell can only be accomplished by manipulating the private
_childrenattribute.What this does
This PR adds a new keyword argument to the
AnchoredSizeBarinitializer that allows users to control thefillkeyword argument passed to theRectanglepatch, making it possible to easily create filled size bars.