Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove wxversion import errors. Closes #885. #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove wxversion import errors. Closes #885. #888

wants to merge 1 commit into from

Conversation

mbauman
Copy link

@mbauman mbauman commented May 22, 2012

It seems silly to me to have wxversion as a hard dependency when it's not a requirement for a proper installation of wx. Especially so since backend_wx.py still checks the VERSION_STRING after using going through all the hoops with wxversion. This is simply an alternative.

@efiring
Copy link
Member

efiring commented May 22, 2012

I think the reason for the wxversion requirement was that people were running into trouble when they had two versions installed; maybe they had 2.6 and 2.8, and the 2.6 was getting imported.

Why is it so onerous to require wxversion?

@mbauman
Copy link
Author

mbauman commented May 22, 2012

You're right, it's not terribly onerous. Indeed, wxPython defaults to building wxversion. Perhaps my package manager (homebrew) simply made a poor choice in choosing to override this.

As a novice, it took me quite a bit of time to determine the problem here. In doing so, I found a stackoverflow question where the poster had similar issues. Add in the fact that the obvious ways to extend the python path (.pth files and $PYTHONPATH) don't respect nested .pth files to an already complicated installation process, and many users will get lost. There's no axe to grind; I'm just trying to save others from the same issues. And indeed, your pull request does accomplish part of that.

@mdboom
Copy link
Member

mdboom commented May 23, 2012

I agree with @efiring: wxversion has been insanely useful in the past. wxpython tends to change APIs wholesale with each release, so having multiple versions installed is a necessity, and wxversion is the most sane way to handle that case. I think I prefer #886 over this.

EDIT: Fixed PR number

@efiring
Copy link
Member

efiring commented May 26, 2012

I'm going to close this and merge #886. An alternative would be to simply warn if wxversion is not present; if discussion indicates that is a good idea, then it can be advanced as a pull request to master.

@efiring efiring closed this May 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants