Remove superfluous list calls from around map #8991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Aug 5, 2017
|
@adeak Thanks! Congratulations on your first Matplotlib contribution 🎉 ! Hopefully we will hear from you again. |
|
@tacaswell Thank you very much, I'm glad I could finally be of use:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 2
mapalready returns a list, and as far as I know (and as checked for 3.5) in python 3 any iterable can be unpacked on assignment.list()calls from unpacking assignments of the formx,y = list(map(fun,seq)).list(map())where the resulting object is directly consumed by anothermapcall on the next line. Considering how this change is qualitatively different from the other, more trivial ones, I separated this change for ease of cherry-picking if necessary.