pcolormesh edgecolors does not work correctly #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to draw_quad_mesh.
|
The attached PR should allow for passing edgecolors to pcolormesh. You can even pass a list of colors if you like. |
efiring
added a commit
that referenced
this pull request
May 31, 2012
pcolormesh edgecolors does not work correctly
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
Jun 6, 2012
edgecolors='None' now must be included explicitly. Even if this change in the default is reverted, it makes sense for colorbar to be explicit about it.
mdboom
added a commit
to mdboom/matplotlib
that referenced
this pull request
Jun 7, 2012
…b#929. The default behavior of pcolormesh should be to draw no edges if no `edgecolors` kwarg is provided.
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
Jul 9, 2012
efiring
added a commit
that referenced
this pull request
Jul 9, 2012
Fix bug in pcolorfast introduced by #901
| @@ -7224,13 +7219,8 @@ def pcolormesh(self, *args, **kwargs): | |||
| coords[:, 0] = X | |||
| coords[:, 1] = Y | |||
|
|
|||
| if shading == 'faceted' or edgecolors != 'None': | |||
There was a problem hiding this comment.
Direct "None" comparison excludes the use of the lowercase "none" equivalent. I will open a ticket for this.
There was a problem hiding this comment.
Note this is a line that was removed, not introduced by this PR.
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Aug 31, 2012
…nged when matplotlib#901 and was merged, to allow different edgecolors, due to the way get_edgecolors behave. This restors the original behavior of colorbar in both mpl and the axisgrid1 toolkit by setting the edgecolor to 'face'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the following code produces a mesh with black edges:
Looking at the matplotlib code, it looks like the
draw_quad_meshrenderer method should really take an argument for edgecolors rather than just setting the edges to black by default.