Thanks to visit codestin.com
Credit goes to github.com

Skip to content

replace cairo.format with savefig.format in rcParams #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 6 commits into from
Jun 6, 2012
Merged

replace cairo.format with savefig.format in rcParams #907

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e58fa07
replace cairo.format with savefig.format in rcParams, apply to most b…
mspacek May 28, 2012
42002e2
check validity of savefig.format rcParam at runtime
mspacek May 31, 2012
6d6da54
update CHANGELOG and get_default_filetype docstring
mspacek May 31, 2012
b822c26
replace stray tabs with spaces in api_changes.rst
mspacek Jun 1, 2012
8cdc0da
deprecate 'savefig.extension' rcParam in favour of 'savefig.format'
mspacek Jun 1, 2012
bec0a4a
allow any string for rcParams['savefig.format'], leave validity check…
mspacek Jun 3, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check validity of savefig.format rcParam at runtime 
remove support for 'cairo.pdf' type of backend specification
  • Loading branch information
@mspacek
mspacek committed Jun 3, 2012
commit 42002e27423716ebf9f0971928f89c1d6f56fadb
5 changes: 1 addition & 4 deletions lib/matplotlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,10 +939,7 @@ def use(arg, warn=True):
else:
# Lowercase only non-module backend names (modules are case-sensitive)
arg = arg.lower()
be_parts = arg.split('.')
name = validate_backend(be_parts[0])
if len(be_parts) > 1:
raise ValueError('FIXME: Not sure what to do here')
name = validate_backend(arg)
rcParams['backend'] = name

def get_backend():
Expand Down
12 changes: 11 additions & 1 deletion lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1897,6 +1897,7 @@ def print_tif(self, filename_or_obj, *args, **kwargs):
print_tiff = print_tif

def get_supported_filetypes(self):
"""Return dict of savefig file formats supported by this backend"""
return self.filetypes

def get_supported_filetypes_grouped(self):
Expand Down Expand Up @@ -2078,7 +2079,16 @@ def print_figure(self, filename, dpi=None, facecolor='w', edgecolor='w',


def get_default_filetype(self):
Copy link
Copy Markdown
Member

@pelson pelson May 29, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my earlier comment, this method could really do with a docstring (whilst your there, get_supported_filetypes() and get_supported_filetypes_grouped() should get a docstring too, if possible).

return rcParams['savefig.format']
"""
Get the default savefig file format as specified in rcParams.
If invalid, use .png. Overridden in backends that only support
a single file type.
"""
default = rcParams['savefig.format']
if default in self.get_supported_filetypes():
return default
else:
return 'png'

def set_window_title(self, title):
"""
Expand Down