Remove Artist.{get,set}_axes. #9128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91dccba to
e0551fb
Compare
|
Suspect they also need to be removed from some rst files. |
They are deprecated, and have been planned for removal in 2.0.
e0551fb to
f7ec3b1
Compare
tacaswell
reviewed
Aug 31, 2017
|
|
||
| # the axes class has a second argument inframe for its draw method. | ||
| @wraps(draw) |
There was a problem hiding this comment.
Do not have is an issue with this, but why?
There was a problem hiding this comment.
Because I don't think adding an extra layer of indirection really helps with clarity -- does it?
There was a problem hiding this comment.
No, think this will make many tracebacks a few levels shorter. I asked this before I fully groked that this is all inside of a decorator!
tacaswell
approved these changes
Aug 31, 2017
dstansby
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are deprecated, and have been planned for removal in 2.0. (2.1 will be the second minor release since deprecation, 2.2 the third).
PR Summary
PR Checklist