Fix matplotlib corrupting PySide #9169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t20100 Thanks for the investigation and the fix! Congratulations on your first matplotlib PR 🎉 |
tacaswell
added a commit
that referenced
this pull request
Sep 18, 2017
Fix matplotlib corrupting PySide
|
backported to v2.1.x as 6ab5288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR avoids matplotlib Qt backend to delete
QWidget.__init__when using PySide.This resulted in exceptions when instantiating other QWidgets after the instantiation of a FigureCanvasQTAgg.
I tested with PySide, PyQt4 and PyQt5 with both python 2.7 and 3.4 on Debian8.
I could not test it with PySide2.
Code to reproduce is available in #9162.
Addresses #9162.
PR Checklist