Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove some unused scripts #9174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 9, 2017

Makefile: DISTFILES is out of date (e.g. KNOWN_BUGS has been removed
back in 2011) so the targets cannot be make'd.

distribute_setup.py: Essentially superceded by ensurepip these days.

release/win32/data/setupwin{,egg}.py: Not updated since 2009, not
mentioned by any Windows install guide, and who uses eggs these days
anyways?

doc/utils/pylab_names.py: for example, the links it generates (to
http://sd-2116.dedibox.fr/pydocweb/doc) are broken.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the remove-pylab-names-script branch from 3ac8e23 to 9bec81d Compare September 10, 2017 20:02
@anntzer anntzer changed the title Remove the unused doc/utils/pylab_names.py script. Remove some unused scripts Sep 10, 2017
Makefile: DISTFILES is out of date (e.g. KNOWN_BUGS has been removed
back in 2011) so the targets cannot be make'd.

distribute_setup.py: Essentially superceded by ensurepip these days.

release/win32/data/setupwin{,egg}.py: Not updated since 2009, not
mentioned by any Windows install guide, and who uses eggs these days
anyways?

doc/utils/pylab_names.py: for example, the links it generates (to
http://sd-2116.dedibox.fr/pydocweb/doc) are broken.
@anntzer anntzer force-pushed the remove-pylab-names-script branch from 9bec81d to 7a0cbc3 Compare September 10, 2017 20:09
@tacaswell tacaswell added this to the 2.2 (next next feature release) milestone Sep 24, 2017
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit wary of changing setup.py

@anntzer
Copy link
Contributor Author

anntzer commented Sep 24, 2017

Then you should be wary of https://github.com/anntzer/matplotlib/tree/WIP-setupext-rewrite because that's coming soon :-) (but I learnt not to have too many "big" PRs open at the same time)...

(Preview: Remove numpy from setup_requires, so that pip install in the absence of numpy doesn't try to fetch the numpy sdist and build it locally; numpy is still listed in the install_requires and will thus still get installed properly before the extensions that need it are built. Get rid of MPLLOCALFREETYPE in favor of symbol interposition (with building Freetype 2.6.1 split out to an independent script), so that you don't need a special build of Matplotlib to run the tests. Don't use multiprocessing anymore in setupext, which removes a few workarounds. Just let the compiler use standard paths (modifiable via standard environment variables) when building Matplotlib, so that, in particular, python setup.py build "just works" from a Windows conda env without any trickery. Make the Windows build configurable between static and dynamic linking via setup.py.)

@NelleV NelleV merged commit 17ec416 into matplotlib:master Sep 30, 2017
@anntzer anntzer deleted the remove-pylab-names-script branch September 30, 2017 19:37
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants