Don't fail on empty autoscale_None. #9195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a good idea to add |
We reuse the same strategy as in the default Normalize.autoscale_None. First convert the input to an array because that's what np.size and np.ma.min/max do anyways, so it's more efficient to do it just once.
c95c964 to
ae57ee6
Compare
|
done |
tacaswell
approved these changes
Sep 17, 2017
dstansby
approved these changes
Sep 17, 2017
|
Thank you! |
dstansby
added a commit
that referenced
this pull request
Sep 19, 2017
Don't fail on empty autoscale_None.
|
Backported to |
QuLogic
reviewed
Oct 7, 2017
| colors.LogNorm, | ||
| lambda: colors.SymLogNorm(1), | ||
| lambda: colors.PowerNorm(1)]) | ||
| @pytest.mark.filterwarnings("ignore:Attempting to set identical left==right") |
There was a problem hiding this comment.
For future reference, this was added in pytest 3.2 and our docs only say we require 3.0, so it probably shouldn't be relied upon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9194.
We reuse the same strategy as in the default Normalize.autoscale_None.
First convert the input to an array because that's what np.size and
np.ma.min/max do anyways, so it's more efficient to do it just once.
PR Summary
PR Checklist