Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: use str (not unicode) to ensure comparison works on python2 #9228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2017
Merged

FIX: use str (not unicode) to ensure comparison works on python2 #9228

merged 1 commit into from
Sep 25, 2017

Conversation

tacaswell
Copy link
Member

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Sep 25, 2017
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 25, 2017
@tacaswell
Copy link
Member Author

It seems that the wheels do not work for 2.7 so we missed this issue.

@anntzer anntzer merged commit 8982026 into matplotlib:v2.1.x Sep 25, 2017
@anntzer
Copy link
Contributor

anntzer commented Sep 25, 2017

We missed the issue because we're not testing the GUI toolkits at all (except that TkAgg can be imported) on Py2.

@tacaswell tacaswell deleted the fix_wx_versioncheck_lpy branch September 25, 2017 21:16
@tacaswell
Copy link
Member Author

We are installing wx on the 2.7 build, how hard would it be to run the tests?

@anntzer
Copy link
Contributor

anntzer commented Sep 25, 2017

See #8660 (comment). subprocess32 has timeout but right now it's only installed on {posix and py2} (where it is an actual dependency). I dropped the test on Py2 because subprocess32 appears unsupported on windows but we can probably change it to drop the test only on Py2+windows...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @anntzer @dopplershift