Non string serialised projections #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,8 +229,10 @@ def __init__(self, *args, **kwargs): | |||
| each pair of data points. Set to 1 to disable | |||
| interpolation. | |||
| """ | |||
| self.resolution = kwargs.pop('resolution', 1) | |||
| self._default_theta_offset = kwargs.pop('theta_offset', 0) | |||
There was a problem hiding this comment.
To clarify, currently when creating a PolarAxes with a theta_offset kwarg, Axes.__init__ uses setp to set the value, but PolarAxes.gca wipes it again. This fixes this behaviour and is tested in my new _as_mpl_axes test.
|
Barring a couple of documentation-related improvements, I think this is ready to go in. |
|
I think the latest commit improves the situation. Is this the kind of thing you had in mind? |
|
Much better, thanks. |
|
I'll rebase now then and then give it 24 hours before merging. |
pelson
pushed a commit
that referenced
this pull request
Jun 13, 2012
Support for non string projections, exposing the _as_mpl_axes external API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #694, which itself was a rebase of #470.
I would like the ability to setup a plot projection in MPL that can be defined by various parameters and does not need to be serialised as a string and registered with matplotlib.projections.register_projection. For example, an extension of /examples/api/custom_projection_example.py might be to add the ability to define the central meridian to an arbitrary value rather than the current value of 0 - in this case I would expect to define the projection by creating an object which can then be turned into a matplotlib axes: