Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix passing shape (2,) input to Collections.set_offsets. #9232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2017
Merged

Fix passing shape (2,) input to Collections.set_offsets. #9232

merged 1 commit into from
Sep 28, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 26, 2017

The logic with uniform_offsets seems a bit crazy but let's just
reproduce it for now...

xref https://gitter.im/matplotlib/matplotlib?at=59c9cfe7f7299e8f5371689b

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer requested a review from QuLogic September 26, 2017 09:10
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Sep 26, 2017
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 26, 2017
@tacaswell
Copy link
Member

This is a regression from 2.0.

@QuLogic
Copy link
Member

QuLogic commented Sep 26, 2017

This seems to have broken something; probably the object() somewhere.

@anntzer anntzer force-pushed the fix-collections-offsets branch 2 times, most recently from 9ccda79 to c92ccc0 Compare September 27, 2017 00:53
@anntzer @tacaswell
Fix passing shape (2,) input to Collections.set_offsets.
c5170ec 
The logic with uniform_offsets seems a bit crazy but let's just
reproduce it for now...
@tacaswell tacaswell force-pushed the fix-collections-offsets branch from c92ccc0 to c5170ec Compare September 28, 2017 05:49
@tacaswell
Copy link
Member

rebased on current master and force-pushed.

QuLogic
QuLogic approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for my simplified test case and the original test code.

@tacaswell tacaswell merged commit 4fe22e1 into matplotlib:master Sep 28, 2017
tacaswell added a commit that referenced this pull request Sep 28, 2017
@tacaswell
Merge pull request #9232 from anntzer/fix-collections-offsets
df1b18e 
Fix passing shape (2,) input to Collections.set_offsets.
@tacaswell
Copy link
Member

backported to v2.1.x as df1b18e

@anntzer anntzer deleted the fix-collections-offsets branch September 28, 2017 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic