Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix download of freetype 2.6.1. #9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 27, 2017

by checking file hash before exiting the download loop.

attn @QuLogic

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

by checking file hash before exiting the download loop.
@anntzer anntzer force-pushed the freetype261-download branch from e5174f8 to fe311da Compare September 27, 2017 16:52
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Sep 27, 2017
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 27, 2017
@dopplershift dopplershift merged commit affc5c6 into matplotlib:master Sep 27, 2017
@dopplershift
Copy link
Contributor

@meeseeksdev backport to v2.1.x

@anntzer anntzer deleted the freetype261-download branch September 27, 2017 20:08
@dopplershift
Copy link
Contributor

Ok, I'm not seeing a new PR for the back port...

@tacaswell
Copy link
Member

it only listens to fixed list of people right now, you may not be on it.

@meeseeksdev backport to v2.1.x

lumberbot-app bot pushed a commit that referenced this pull request Sep 27, 2017
by checking file hash before exiting the download loop.

attn  QuLogic

<!--Thank you so much for your PR! To help us review, fill out the form
to the best of your ability.  Please make use of the development guide at
https://matplotlib.org/devdocs/devel/index.html-->

<!--Provide a general summary of your changes in the title above, for
example "Raises ValueError on Non-Numeric Input to set_xlim".  Please avoid
non-descriptive titles such as "Addresses issue  8576".-->

<!--If you are able to do so, please do not create the
PR out of master, but out of a separate branch.  See
https://matplotlib.org/devel/gitwash/development_workflow.html for
instructions.-->

   PR Summary

<!--Please provide at least 1-2 sentences describing the pull request in
detail.  Why is this change required?  What problem does it solve?-->

<!--If it fixes an open issue, please link to the issue here.-->

   PR Checklist

- [ ] Has Pytest style unit tests
- [ ] Code is PEP 8 compliant
- [ ] New features are documented, with examples if plot related
- [ ] Documentation is sphinx and numpydoc compliant
- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

<!--We understand that PRs can sometimes be overwhelming, especially as the
reviews start coming in.  Please let us know if the reviews are unclear or the
recommended next step seems overly demanding , or if you would like help in
addressing a reviewer's comments.  And please ping us if you've been waiting
too long to hear back on your PR.-->
@lumberbot-app lumberbot-app bot mentioned this pull request Sep 27, 2017
6 tasks
@dopplershift
Copy link
Contributor

Good, less work for me. 😝

tacaswell added a commit that referenced this pull request Sep 27, 2017
@Carreau
Copy link
Contributor

Carreau commented Oct 2, 2017

Good, less work for me.

I think you are on the whitelist now.
Also ; if you edit the 2.1 milestone on add in the description field:

on-merge: backport to v2.1.x

On a line on it's own (you can do several on-merge line), it should auto-trigger.
The milestone should be before merging of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants