Fix a possible infinite loop by incrementing one of the variables used in the loop conditional. #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. This should probably go on the v1.1.x branch. |
| @@ -1067,7 +1067,7 @@ | |||
| double r, g, b, alpha; | |||
| const size_t N = imo->rowsIn * imo->colsIn; | |||
| size_t i = 0; | |||
| while (i < N) | |||
| while (i++ < N) | |||
There was a problem hiding this comment.
Why don't we just say
for (size_t i = 0; i < N; ++i)
to make it even more obvious there's nothing special about this loop.
There was a problem hiding this comment.
A for loop would be fine too. We were just trying to keep with the original style.
…d in the loop conditional. This was detected by Richard Trieu when compiling with clang.
| @@ -1066,8 +1066,7 @@ | |||
| int rgba = A->dimensions[2] == 4; | |||
| double r, g, b, alpha; | |||
| const size_t N = imo->rowsIn * imo->colsIn; | |||
| size_t i = 0; | |||
| while (i < N) | |||
| for (size_t i = 0; i < N; ++i) | |||
|
@idealisms Could you rebase this against the v1.1.x branch so it can make it into the upcoming release? |
|
I'm closing this, since it's been merged in to v1.1.x and will be merged into master on the next v1.1.x merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a possible infinite loop by incrementing one of the variables used in the loop conditional.
This was detected by Richard Trieu when compiling with clang.