Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't leak test.jpeg into cwd while testing. #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2017
Merged

Don't leak test.jpeg into cwd while testing. #9486

merged 1 commit into from
Oct 20, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 20, 2017

Use an in-memory buffer instead.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Don't leak test.jpeg into cwd while testing.
798a428 
Use an in-memory buffer instead.
Kojoley
Kojoley reviewed Oct 20, 2017
View reviewed changes
lib/matplotlib/tests/test_agg.py
im = Image.open("test.jpg")
buf = io.BytesIO()
plt.savefig(buf, format="jpg", dpi=200)
im = Image.open(buf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not remember details, but from my previous experience this should not work without a buf.seek(0) call.
However CI is fine...

dopplershift
dopplershift approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to avoiding going to the filesystem when possible.

I can confirm locally that it works without needing to seek.

@NelleV NelleV merged commit 119effd into matplotlib:master Oct 20, 2017
@anntzer anntzer deleted the test-file-leak branch October 20, 2017 18:37
@QuLogic QuLogic added this to the v2.2 milestone Oct 20, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kojoley Kojoley Kojoley left review comments

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @dopplershift @Kojoley @NelleV @QuLogic