Attribute users/intro to JDH and rename to history. #9515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just in case anyone is wondering for the trademarks: the signs are clearly not necessary, see e.g. https://academia.stackexchange.com/a/61852
Kojoley
reviewed
Oct 28, 2017
| @@ -12,7 +12,7 @@ User's Guide | |||
| .. toctree:: | |||
| :maxdepth: 2 | |||
|
|
|||
| intro.rst | |||
| history.rst | |||
There was a problem hiding this comment.
I am not familiar with guide writing but it seems odd to me that user guide starts with a history chapter.
There was a problem hiding this comment.
I don't think many people read the docs in linear order tbh
efiring
approved these changes
Oct 29, 2017
anntzer
added a commit
that referenced
this pull request
Oct 30, 2017
Backport PR #9515 on branch v2.1.0-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case anyone is wondering for the trademarks:
the signs are clearly not necessary, see e.g.
https://academia.stackexchange.com/a/61852
git blame points to f0f28a3 as origin of the text.
Closes #9348.
PR Summary
PR Checklist