Fix typo in isinstance#9589
Merged
anntzer merged 1 commit intomatplotlib:masterfrom Oct 27, 2017
Merged
Conversation
WeatherGod
approved these changes
Oct 26, 2017
Member
WeatherGod
left a comment
There was a problem hiding this comment.
Good catch! Will merge once tests finish.
Contributor
|
Thanks, hoping to see you around again! |
Member
|
@meeseeksdev backport to v2.1.x (Am I even whitelisted, though?) |
Member
I guess that's a yes, then. |
QuLogic
added a commit
that referenced
this pull request
Oct 27, 2017
Backport PR #9589 on branch v2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo in
isinstancecaused the logic here to evaluate to, for example,(False, (basestring,))which evaluates toTrue.