Correctly convert units for a stacked histogram #9654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
reviewed
Nov 1, 2017
lib/matplotlib/axes/_axes.py
Outdated
| self._process_unit_info(xdata=x[0], kwargs=kwargs) | ||
| newx = [] | ||
| for xi in x: | ||
| newx.append(self.convert_xunits(xi)) |
There was a problem hiding this comment.
x = [self.convert_xunits(xi) for xi in x] ?
QuLogic
reviewed
Nov 1, 2017
lib/matplotlib/axes/_axes.py
Outdated
| # Massage 'x' for processing. | ||
| if input_empty: | ||
| x = np.array([[]]) | ||
| else: | ||
| x = cbook._reshape_2D(x, 'x') | ||
| nx = len(x) # number of datasets | ||
|
|
||
| # Process unit information | ||
| # If doing a stacked histogram, the input is a list of datasets, so | ||
| # we need to do the unit conversion individually on eaach dataset |
f66d5c5 to
a09798e
Compare
a09798e to
c02a84d
Compare
dopplershift
approved these changes
Nov 1, 2017
efiring
requested changes
Nov 11, 2017
lib/matplotlib/axes/_axes.py
Outdated
| # we need to do the unit conversion individually on each dataset | ||
| if stacked: | ||
| self._process_unit_info(xdata=x[0], kwargs=kwargs) | ||
| x = [self.convert_xunits(xi) for xi in x] |
There was a problem hiding this comment.
I don't understand: it seems to me that the criterion for needing this step is not whether the histogram is stacked, but whether x is a list of datasets.
There was a problem hiding this comment.
I think you're right, I'll change this and add a test for multiple datasets that aren't stacked
efiring
approved these changes
Nov 14, 2017
efiring
requested changes
Nov 14, 2017
lib/matplotlib/axes/_axes.py
Outdated
| # Massage 'x' for processing. | ||
| if input_empty: | ||
| x = np.array([[]]) | ||
| x = [np.array([[]])] |
There was a problem hiding this comment.
Too many square brackets--I think this should be a list with one empty 1-D array, not with an empty 2-D array.
efiring
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5898. Hopefully the comment I've added in the code should make it clear what's going on.