Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove a few unnecessary global statements. #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2017
Merged

Remove a few unnecessary global statements. #9678

merged 1 commit into from
Nov 5, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 4, 2017

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Kojoley
Kojoley approved these changes Nov 4, 2017
View reviewed changes
Copy link
Member

@Kojoley Kojoley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: Is there any reason to have a module variable qApp? It is only used in test_backend_qt5 while other places uses QtWidgets.QApplication.instance() and QtWidgets.qApp

matplotlib/lib/matplotlib/backends/backend_qt5.py

Line 564 in 303ebb6

if QtWidgets.QApplication.instance() is None:

matplotlib/lib/matplotlib/backends/qt_editor/formlayout.py

Line 504 in 409d8b7

if QtWidgets.QApplication.startingUp():

matplotlib/lib/matplotlib/pyplot.py

Line 93 in 8989a6f

if not PyQt5.QtWidgets.qApp.startingUp():

@Kojoley Kojoley added this to the v2.2 milestone Nov 4, 2017
@anntzer
Copy link
Contributor Author

anntzer commented Nov 4, 2017

Yes: a python-level reference to that object must be kept to prevent it from being GC'd (QtWidgets.qApp and QApplication.instance() do not prevent it from being GC'd).
(Now we may hide that reference to some non-global place but that's another story.)

@dopplershift dopplershift merged commit 2674a4c into matplotlib:master Nov 5, 2017
@anntzer anntzer deleted the global branch November 5, 2017 07:26
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@Kojoley Kojoley Kojoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @Kojoley @QuLogic