FIX/TST: update tests for pandas 0.21 #9726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Nov 9, 2017
lib/matplotlib/tests/test_axes.py
Outdated
| @@ -5073,6 +5077,9 @@ def test_pandas_indexing_dates(): | |||
|
|
|||
| def test_pandas_errorbar_indexing(): | |||
| pd = pytest.importorskip('pandas') | |||
| from pandas.tseries import converter | |||
| converter.register() | |||
|
|
|||
There was a problem hiding this comment.
PEP8 doesn't like this blank line, otherwise tests seem to be fine.
|
so unclear if this code actually reduces coverage or if it's an artifact of a different PR. |
|
Sometimes I feel like I need an undergraduate degree in codecov just to understand codecov... I think the issue is that there are two tests both named |
|
Huh, did I do that? Anyhow, should be fixed now barring other foolishness |
dstansby
approved these changes
Nov 9, 2017
|
@meeseeksdev backport to v2.1.x |
|
There seem to be a conflict, please backport manually |
tacaswell
pushed a commit
that referenced
this pull request
Nov 10, 2017
FIX/TST: update tests for pandas 0.21
Conflicts:
.appveyor.yml
conflicts due thrashing around pandas version pinning
|
manually backported via ce45bea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #9610.
As of pandas 0.21,
import pandasno longer callsso it has been added to the tests.
Surprisingly no examples depend on pandas, so that made life simpler.
PR Summary
PR Checklist