Allow _BackendNbAgg.show() to take keyword "block" #9733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes matplotlib#9729 Doesn't actually handle block (if it should).
tacaswell
approved these changes
Nov 9, 2017
|
Do we need a new issue to take care of the todo? Or does block not make sense on nbagg anyway? |
jklymak
approved these changes
Nov 9, 2017
|
I don't think blocking makes sense in the notebook. |
anntzer
added a commit
that referenced
this pull request
Nov 10, 2017
Backport PR #9733 on branch v2.1.x
|
Thanks @dsblank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9729
Doesn't actually handle block (if it should).
PR Summary
PR Checklist