Reword subplot() doc. #9748
Merged
Reword subplot() doc. #9748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49e5ba2 to
c60434a
Compare
jklymak
approved these changes
Nov 11, 2017
|
The previous wording had "across rows first" which I guess is kind of ambiguous. |
phobson
approved these changes
Nov 11, 2017
|
If I'm still up when the CI finishes, I'll merge |
|
"...increasing along rows, (row-major order)."? Small point, but I find "row-major" too jargony and ambiguous w/o looking it up |
|
What I worded as "increasing along rows" you thought should be worded "increasing along columns", which I think clearly indicates that that phrase is not well-defined... |
dstansby
approved these changes
Nov 11, 2017
|
Well, I think you worded it as "across rows" which is the opposite of "along rows" in my mind ;-) |
Kojoley
added a commit
that referenced
this pull request
Nov 11, 2017
Backport PR #9748 on branch v2.1.x
|
The previous version also had across... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9740.
Feel free to directly push additional edits.
I intentionally replaced "typical call signature" by "call signature" for simplicity.