Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Additions to the documentation guide #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Nov 28, 2017

This is an enhacement to the great work of #9805. The aforementioned PR addresses many points of #9786 and closed it.

IMHO there were some additional points worth mentioning. I've added them in this pull request, before they get lost. The content stems from the discussion in #9786 and the issues linked therein. I hope, I've got everyting right.

Note: I'm aware of #9872, which addresses other enhancements to the documentation guide.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just note that the outlining will need to be reconciled at merge. If mine is accepted as is, you'll need to move this down a level. (~~~~)

Pending tests ;-)


Additional formatting conventions
---------------------------------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Note I knocked all this down a level in the outline, so we'll have to remember to reconcile. Actually my new outlining is somewhat incomplete the way I've done it, but I thought I'd leave it like that to at least remind myself that it needed fixing.

projection :
['aitoff' | 'hammer' | 'lambert' | 'mollweide' | \
'polar' | 'rectilinear'], optional
The projection type of the axes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close the triple quotes here (possibly after an ellipsis)

@dstansby dstansby added this to the v2.1.0-doc milestone Nov 29, 2017
@dstansby dstansby merged commit e36822f into matplotlib:master Nov 29, 2017
dstansby added a commit that referenced this pull request Nov 29, 2017
@timhoffm timhoffm deleted the doc-guide branch November 29, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants