Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Lock pytest to 3.2.5 until 3.3.1 released #9878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Nov 29, 2017

PR Summary

As per @QuLogic comments in #9867 Appveyor tests are breaking because of a change to pytest 3.3.0 pytest-dev/pytest#2957 Until 3.3.1 is released this locks us to 3.2.5 on appveyor.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member Author

jklymak commented Nov 29, 2017

Note pytest has a fix: pytest-dev/pytest#2969

@jklymak jklymak changed the title TST: Lock pytest to 3.2.5 until 3.3.1 released WIP: TST: Lock pytest to 3.2.5 until 3.3.1 released Nov 29, 2017
@jklymak
Copy link
Member Author

jklymak commented Nov 29, 2017

Looks like the error has spread to Travis as well. If someone can fix it before I do feel free to push onto this branch

@QuLogic QuLogic added this to the v2.1.1 milestone Nov 29, 2017
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes...

@tacaswell
Copy link
Member

You can also do !=3.3.0 which is a bit more robust.

@tacaswell
Copy link
Member

but, not worth holding the PR over that.

@jklymak
Copy link
Member Author

jklymak commented Nov 29, 2017

Oh cool!

@jklymak jklymak force-pushed the tst-fix-pytest-appveyor branch from 40dcd42 to e39a03a Compare November 29, 2017 02:39
@jklymak jklymak changed the title WIP: TST: Lock pytest to 3.2.5 until 3.3.1 released TST: Lock pytest to 3.2.5 until 3.3.1 released Nov 29, 2017
@jklymak
Copy link
Member Author

jklymak commented Nov 29, 2017

This basically passes (Xcode check not done). Prob should be merged soon if OK by everyone...

@dstansby dstansby merged commit 715cfa6 into matplotlib:master Nov 29, 2017
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 29, 2017

There seem to be a conflict, please backport manually

@jklymak
Copy link
Member Author

jklymak commented Nov 29, 2017

Hmmmm, how does this get manually backported (if needed?)

@tacaswell
Copy link
Member

backported to v2.1.0-doc in #9885 and merged to 2.1.x in 55830e5

@jklymak jklymak deleted the tst-fix-pytest-appveyor branch March 5, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants