-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix issue #7372, move widget functions into matplotlib.testing.widgets. #9905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
""" | ||
======================== | ||
Widget testing utilities | ||
======================== | ||
|
||
Functions that are useful for testing widgets. | ||
See also matplotlib.tests.test_widgets | ||
""" | ||
|
||
import matplotlib.pyplot as plt | ||
|
||
try: | ||
# mock in python 3.3+ | ||
from unittest import mock | ||
except ImportError: | ||
import mock | ||
|
||
|
||
def get_ax(): | ||
fig, ax = plt.subplots(1, 1) | ||
ax.plot([0, 200], [0, 200]) | ||
ax.set_aspect(1.0) | ||
ax.figure.canvas.draw() | ||
return ax | ||
|
||
|
||
def do_event(tool, etype, button=1, xdata=0, ydata=0, key=None, step=1): | ||
""" | ||
*tool* | ||
a matplotlib.widgets.RectangleSelector instance | ||
|
||
*etype* | ||
the event to trigger | ||
|
||
*xdata* | ||
x coord of mouse in data coords | ||
|
||
*ydata* | ||
y coord of mouse in data coords | ||
|
||
*button* | ||
button pressed None, 1, 2, 3, 'up', 'down' (up and down are used | ||
for scroll events) | ||
|
||
*key* | ||
the key depressed when the mouse event triggered (see | ||
:class:`KeyEvent`) | ||
|
||
*step* | ||
number of scroll steps (positive for 'up', negative for 'down') | ||
""" | ||
event = mock.Mock() | ||
event.button = button | ||
ax = tool.ax | ||
event.x, event.y = ax.transData.transform([(xdata, ydata), | ||
(xdata, ydata)])[00] | ||
event.xdata, event.ydata = xdata, ydata | ||
event.inaxes = ax | ||
event.canvas = ax.figure.canvas | ||
event.key = key | ||
event.step = step | ||
event.guiEvent = None | ||
event.name = 'Custom' | ||
|
||
func = getattr(tool, etype) | ||
func(event) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am 50/50 on moving this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the name of this function does not reflect its body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you should give it a better name in testing. I assume that functions defined in tests are not part of the public api. So this change would be matplotlib-internal.