Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unused import in toolmanager example #9986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

Remove unused import in toolmanager example #9986

merged 1 commit into from
Dec 13, 2017

Conversation

dstansby
Copy link
Member

I have no idea what these imports are meant to do, but they aren't referenced anywhere else and I can run the example fine without them.

@tacaswell tacaswell added this to the v2.1.1-doc milestone Dec 13, 2017
@tacaswell tacaswell merged commit 64ffc46 into matplotlib:master Dec 13, 2017
@dstansby dstansby deleted the toolmanager-example branch December 13, 2017 11:06
@QuLogic
Copy link
Member

QuLogic commented Dec 15, 2017

@Carreau @tacaswell These are marked for old milestones, but it seems that @meeseeksdev doesn't backport because the branch doesn't exist. However, it doesn't even post a message that it failed.

@Carreau
Copy link
Contributor

Carreau commented Dec 15, 2017 •
edited
Loading

Indeed, thanks for the ping, I've looked at the log and there is indeed a crash:

ERROR:tornado.application:Uncaught exception POST /webhook (10.181.102.139) 
Traceback (most recent call last): 
  File "/app/.heroku/python/lib/python3.6/site-packages/tornado/web.py", line 1467, in _execute 
    result = method(*self.path_args, **self.path_kwargs) 
  File "/app/meeseeksdev/meeseeksbox/core.py", line 129, in post 
    return self.dispatch_action(action, payload) 
  File "/app/meeseeksdev/meeseeksbox/core.py", line 214, in dispatch_action 
    self.dispatch_on_mention('@meeseeksdev '+todo, payload, merged_by['login']) 
  File "/app/meeseeksdev/meeseeksbox/core.py", line 311, in dispatch_on_mention 
    session=session, payload=payload, arguments=arguments) 
  File "/app/meeseeksdev/meeseeksbox/commands.py", line 236, in backport 
    repo.remotes.origin.fetch('refs/heads/{}:workbranch'.format(target_branch)) 
  File "/app/.heroku/python/lib/python3.6/site-packages/git/remote.py", line 752, in fetch 
    res = self._get_fetch_info_from_stderr(proc, progress) 
  File "/app/.heroku/python/lib/python3.6/site-packages/git/remote.py", line 638, in _get_fetch_info_from_stderr 
    proc.wait(stderr=stderr_text) 
  File "/app/.heroku/python/lib/python3.6/site-packages/git/cmd.py", line 291, in wait 
    raise GitCommandError(self.args, status, errstr) 
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128) 
  cmdline: git fetch -v origin refs/heads/v2.1.1-doc:workbranch 
  stderr: 'fatal: Couldn't find remote ref refs/heads/v2.1.1-doc' 
commits were likely pushed....

I'll investigate tomorrow (In europe and it's late), otherwise the code is there

@Carreau
Copy link
Contributor

Carreau commented Dec 17, 2017

It should now push a message when it fails.
What you can do is create the right branch, and then mention @<botname> backport to <branchname> to trigger it manually. I can't I'm not comiter so it won't respond to me on this repo.

@QuLogic
Copy link
Member

QuLogic commented Dec 24, 2017

@meeseeksdev backport to v2.1.1-doc

@lumberbot-app lumberbot-app bot mentioned this pull request Dec 24, 2017
Merged
lumberbot-app bot pushed a commit that referenced this pull request Dec 24, 2017
@tacaswell
Backport PR #9986: Remove unused import in toolmanager example
0cbc974
QuLogic added a commit that referenced this pull request Dec 24, 2017
@QuLogic
Merge pull request #10081 from matplotlib/auto-backport-of-pr-9986
e995e25 
Backport PR #9986 on branch v2.1.1-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.1.1-doc
Development

Successfully merging this pull request may close these issues.
5 participants
@dstansby @QuLogic @Carreau @anntzer @tacaswell