ENH: Add Makefile for local development testing of build #8
Conversation
|
|
||
| run: | ||
| docker run --rm -it \ | ||
| -v $(shell pwd):/mpl_source \ |
There was a problem hiding this comment.
But you should be mounting the Matplotlib source, not this directory.
There was a problem hiding this comment.
No, not for testing the build of this image.
There was a problem hiding this comment.
There's nothing in this repo to test with.
There was a problem hiding this comment.
The Makefile is local to this project. What I mean is that if you're working on refactoring the image and you want to build things locally and then drop into it to look around and play then this Make target is helpful. For use in actually doing things in matplotlib that's a different story. But what @tacaswell is demoing in PR #5 wouldn't ever be using this Makefile. That would need some shell alias or something.
Sorry, I may have a different idea in my head about what the intended use case of this specific repository is. I thought that this was for just developing the Docker image for a canonical matplotlib build/dev environment. Am I on the same train of thought as you, or did I get confused?
There was a problem hiding this comment.
oh sorry! I think that my choice of mpl_source is confusing here(?). I know that this doesn't contain the matplotlib source code, but just thought that as this would be used for matplotlib source that I'd hint at what this image would be used for. If this is bad I'll change it.
f8e3555 to
f26ae9b
Compare
|
As @tacaswell has pointed out, graphical forwarding is needed so I'll need to add in additional bind mounting to the example but environment |
This allows for the user's current working directory to get bind mounted into the container at /mpl_source and also to have the working directory get set to /mpl_source so they are ready to go
f26ae9b to
32a3e1c
Compare
Additionally, as a style change use BASE_IMAGE instead of BUILDER_IMAGE. This is due to Matthew pasting in some code from a multistage Docker build project, but BUILDER makes little sense here, so use a better naming.
32a3e1c to
5d33819
Compare
Resolves #7
Add a very simple
Makefilefor local development testing to build the image. This allows for usingto build the image and
to drop into an interactive session in the image.
This should wait for PR #6 to get merged so that this can be rebased and add in build args.