This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix spaces filtering sometimes lagging behind or behaving oddly #5893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
reviewed
Apr 21, 2021
| // XXX: Room List Store has a bug where updates to the pre-filter during a local echo of a | ||
| // tags transition seem to be ignored, so refire in the next tick to work around it | ||
| setImmediate(() => { | ||
| this.emit(FILTER_CHANGED); |
There was a problem hiding this comment.
I'm not too sure to understand the reason why we have to emit the FILTER_CHANGED event twice?
Could you give me a bit of extra context here?
There was a problem hiding this comment.
The comment above was hoping to cover it,
Without it the room list will ignore this prefilter update and use its internal local echo instead, causing the room to stay in Rooms until the next thing triggers the roomlist to recalculate.
This workaround already existed prior to #5825, that PR removed it assuming that it resolved all such cases, but it did not
germain-gg
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#16978
This was a mutable reference issue, but also unearthed another issue where a room gained its first tag and there was no lastEvent.
Unfortunately also uncovered another edge case behaviour in the RLS with local echoes, temporary workaround had to be brought back (removed in #5825 (comment))