Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 26, 2021

@t3chguy t3chguy requested a review from a team April 26, 2021 13:51
@t3chguy t3chguy marked this pull request as ready for review April 26, 2021 13:51
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, thanks!

let buttonLabel = _t("Skip for now");
if (selectedToAdd.size > 0) {
onClick = async () => {
// TODO rate limiting
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should it have an issue to track...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does and is slated for the immediate future element-hq/element-web#16891

… t3chguy/fix/16628

� Conflicts:
�	src/components/views/dialogs/AddExistingToSpaceDialog.tsx
@t3chguy t3chguy merged commit d203e8f into develop Apr 28, 2021
@t3chguy t3chguy deleted the t3chguy/fix/16628 branch April 28, 2021 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spaces] Iterate personal collection space creation flow use case
2 participants