Gracefully handle OpenSSL errors when fetching changelogs#97
Merged
Conversation
The Ruby OpenSSL implementation has a bug that prevents it from connecting to certain HTTPS servers. This can cause `bundle ui` to crash with `OpenSSL::SSL::SSLError` while trying to fetch changelogs. As a workaround, this commit gracefully handles the error so that the changelog lookup is skipped, rather than crashing altogether. Ultimately the solution is outside the scope this project; users will need to update the `openssl` gem to the latest version. If a user hasn't yet done so, this commit ensures `bundle ui` will at least work without crashing.
96f3780 to
97b1f2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby OpenSSL implementation has a bug that prevents it from connecting to certain HTTPS servers. This can cause
bundle uito crash withOpenSSL::SSL::SSLErrorwhile trying to fetch changelogs.As a workaround, this commit gracefully handles the error so that the changelog lookup is skipped, rather than crashing altogether.
Ultimately the solution is outside the scope this project; users will need to update the
opensslgem to the latest version. If a user hasn't yet done so, this commit ensuresbundle uiwill at least work without crashing.