Codestin Search App

jbattistispiria · 2022-05-31T21:10:59Z

~~Add a new option when creating a poll «Show Voters»~~.
~~Add error when anonymous option is use with show voters option~~.
Add unit tests

Change made after comments:

Add extra information when using the --progress setting

Show extra information on who voted for what during poll in the RHS feed.
The extra information is send in markdown by using a "card" props from the Mattermost API.
Mattermost post add the info icon to the post and create the RHS.

Fix #96

codecov · 2022-06-15T14:00:13Z

Codecov Report

Merging #431 (0bbbc56) into master (f7a2499) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   93.63%   93.78%   +0.14%     
==========================================
  Files          14       14              
  Lines        1289     1320      +31     
==========================================
+ Hits         1207     1238      +31     
  Misses         55       55              
  Partials       27       27

Impacted Files	Coverage Δ
server/plugin/api.go	`91.25% <100.00%> (+0.15%)`	⬆️
server/plugin/command.go	`98.90% <100.00%> (+0.01%)`	⬆️
server/poll/transform.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a2499...0bbbc56. Read the comment docs.

kaakaa

Great 👍 This feature works fine for me, and your changes almost looks great! I left a few review comments and would appreciate your response.

And Let me make one suggestion. How about including the functionality of --show-voters in the existing --progress setting? Separating those two poll settings would make --progress just display the number of votes on buttons, which does not seem useful. And I don't want to increase the number of poll setting as much as possible. How does this sounds for your use case?

kaakaa

I forgot to send comments.

server/poll/transform.go

server/plugin/api.go

jbattistispiria · 2022-06-16T15:58:26Z

About including the functionality of --show-voters in the existing --progress setting, i thought the same thing as you at first and i did the code that way, but i wasn't sure if people using --progress would want to have the extra information sidebar.
So i keep the two settings separated.
I'm open to make the change, let me know if that's go.

kaakaa · 2022-06-17T02:06:09Z

Thanks for sharing your thought, and I understand it. But I still be inclined to include this functionality in --progress. My thought is the following.

The card is not visible unless a user click on it, so it is not obtrusive
A poll with --progress makes the voting user name public as a result, so I don't think it will be a problem if the voting user name is made public during a poll is open
If a poll is created with --progress and --anonymous, with existing implementation, the voting user name will be hidden and anonymity is protected
- In this case, a card doesn't have any useful information, but it would not be bad

If I seem to have missed something, let me know it.

jbattistispiria · 2022-06-17T13:22:13Z

Great. I'll completely agree with you and i will move show-voters with progress.

This converter add more informative on mouse over a name

Use bundle.LocalizeWithConfig instead of MustLocalize, because MustLocalize causes panic if translation is missing.

jbattistispiria · 2022-06-20T19:19:54Z

I made the change to include the functionality of --show-voters in the existing --progress setting.

kaakaa

Thanks 👍 There are 2 additional points that I would like to fix, so please approve them if they looks good.

server/plugin/command.go

server/poll/transform.go

kaakaa

Perfect 👍

kaakaa · 2022-06-22T01:55:17Z

Since Matterpoll is on a way to release v1.5.0, I'd like to wait to merge this PR until the release process moves forward. If the release process seems to take a long time, I'll cut a new branch for release-1.5 and merge this. I'm careful not to generate additional work for this PR.

kaakaa · 2022-07-16T08:23:23Z

Since there is no activity for a month in mattermost/mattermost-marketplace#298, move forward this PR. Thanks again for your contribution @jbattistispiria!

hanzei · 2022-09-18T06:08:21Z

@jbattistispiria This is great, thanks for the contribution. 🎉

Quick q: Does this feature work on mobile?

kaakaa · 2022-09-21T14:04:29Z

No. AFAIK, card props is not supported on Mobile, so RHS information cannot be seen on mobile.

* docs: update how to install goi18n * Update readme for #431 * bump up version * clean up readme

physiker05 · 2024-03-06T09:36:58Z

Hi all! Although a bit outdated... I'd like to know how I get to see this card that shows me the users participating in an open poll? I started a poll using the option --progress, but I don't get to see the stats. Your help is very much appreciated!

kaakaa · 2024-04-23T11:37:51Z

@physiker05 I'm sorry that I didn't catch your comment.
First let me check, what version of matterpoll are you using? If you are using Matterpoll v1.6.0 or later, you should be able to see the icon to open the card by adding the --progress option.

physiker05 · 2024-04-23T12:08:56Z

@kaakaa Thanks for getting back to me! Well, you probably identified the main issue... I'm running on v1.4.0 😁.

Add RHS informations card to show users votes

4fdf71f

kaakaa self-requested a review June 15, 2022 13:40

kaakaa assigned jbattistispiria Jun 15, 2022

kaakaa added Type/Enhancement New feature or request 3. To Review Docs/Needed Requires documentation Tech/Server Plugin Server labels Jun 15, 2022

kaakaa added this to the v1.6.0 milestone Jun 15, 2022

Merge branch 'master' into 96_rhs_votes

9434442

jbattistispiria added 3 commits June 15, 2022 15:27

Fix missing code coverage

6947d2a

Fix missing code coverage for poll

6625ef8

Add show-voters settings to README

bf15c4e

kaakaa requested changes Jun 16, 2022

View reviewed changes

kaakaa reviewed Jun 16, 2022

View reviewed changes

server/poll/transform.go Outdated Show resolved Hide resolved

server/plugin/api.go Outdated Show resolved Hide resolved

kaakaa mentioned this pull request Jun 17, 2022

Update active.de.json #432

Merged

jbattistispiria added 3 commits June 20, 2022 18:39

Move --show-voters with --progress settings

bb1e003

Update to use p.ConvertUserIDToDisplayName

7b0e5a3

This converter add more informative on mouse over a name

Replace localization function in transform.go

d0a0a2a

Use bundle.LocalizeWithConfig instead of MustLocalize, because MustLocalize causes panic if translation is missing.

kaakaa reviewed Jun 21, 2022

View reviewed changes

server/plugin/command.go Outdated Show resolved Hide resolved

server/poll/transform.go Outdated Show resolved Hide resolved

Fix missing localize and converter update

0bbbc56

kaakaa approved these changes Jun 22, 2022

View reviewed changes

kaakaa added 4. To Release Do Not Merge Should not be merged until this label is removed and removed 3. To Review labels Jun 22, 2022

kaakaa mentioned this pull request Jul 9, 2022

Live results #436

Closed

kaakaa merged commit a5fdb7d into matterpoll:master Jul 16, 2022

kaakaa removed the Do Not Merge Should not be merged until this label is removed label Jul 16, 2022

metsuke0 mentioned this pull request Oct 25, 2022

Admin-only view progress #458

Open

q-wertz mentioned this pull request Mar 9, 2023

Release new version #474

Closed

This was referenced Apr 14, 2023

Updating votes doesn't trigger refreshing card body #475

Closed

Release 1.6.0 #476

Closed

kaakaa added a commit that referenced this pull request Apr 14, 2023

Update readme for #431

3ee804b

kaakaa added a commit that referenced this pull request May 2, 2023

Updates for 1.6 (#479)

5bbd0f7

* docs: update how to install goi18n * Update readme for #431 * bump up version * clean up readme

kaakaa mentioned this pull request Apr 19, 2024

[GH-489] add multiple votes for same option #539

Closed

kaakaa added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Apr 23, 2024

Conversation

jbattistispiria commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kaakaa left a comment

Choose a reason for hiding this comment

Uh oh!

kaakaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jbattistispiria commented Jun 16, 2022

Uh oh!

kaakaa commented Jun 17, 2022

Uh oh!

jbattistispiria commented Jun 17, 2022

Uh oh!

jbattistispiria commented Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaakaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaakaa left a comment

Choose a reason for hiding this comment

Uh oh!

kaakaa commented Jun 22, 2022

Uh oh!

kaakaa commented Jul 16, 2022

Uh oh!

hanzei commented Sep 18, 2022

Uh oh!

kaakaa commented Sep 21, 2022

Uh oh!

physiker05 commented Mar 6, 2024

Uh oh!

kaakaa commented Apr 23, 2024

Uh oh!

physiker05 commented Apr 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

jbattistispiria commented May 31, 2022 •

edited

Loading

codecov bot commented Jun 15, 2022 •

edited

Loading

jbattistispiria commented Jun 20, 2022 •

edited

Loading