update readme #37
Merged
update readme #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nadohs
commented
Apr 24, 2016
- remove unnecessary JSON example
- re-order Enconding/Decoding sections
- added section on enconding nested arrays/dictionaries
- added note on extending initialiers into Classes
| let name: String | ||
| var address: String? | ||
| } | ||
| ``` |
Owner
There was a problem hiding this comment.
Why did we remove this? I think its required context for understanding what comes below.
Collaborator
Author
There was a problem hiding this comment.
I thought it was not really necessary in understanding the examples and mostly just felt like more clutter than content. Perhaps I am taking for granted the fact that I am familiar with the context though, so I can certainly add it back in if you think it will add clarity.
Owner
There was a problem hiding this comment.
I think it's confusing to look an extension for struct without this context. We can split this up and put it next to the extension - maybe that might be clearer?
Collaborator
Author
There was a problem hiding this comment.
sounds reasonable, updates have been made and squashed 👍
1) remove unnecessary JSON example 2) re-order Enconding/Decoding sections 3) added section on enconding nested arrays/dictionaries 4) added note on extending initialiers into Classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.