Fixes array parsing #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, thanks for submitting this PR and sorry it has taken awhile to get back to you. I will be sure to review it this week. |
Contributor
Author
|
Please take look at the second PR as well |
Contributor
Author
|
hey. Still waiting for review. We understand that you are busy but I think this stops the progress of this repo. |
Owner
|
LGTM but it could possibly be breaking change so we might want to record this in the README or somewhere visible. I'll let @Nadohs chime in if there are any more comments. |
Contributor
Author
|
I am not sure if this is a breaking change. Because it feels like expected behaviour. |
raylillywhite
added a commit
to sprucehealth/JSONCodable
that referenced
this pull request
Jul 24, 2019
This reverts commit a981afe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #51