Fix subprocess cleanup for multiple MCP clients #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L/connection adjustments
…nnection-adjustments
…ection-adjustments
There was a problem hiding this comment.
Pull Request Overview
This PR fixes subprocess and Docker container cleanup issues when multiple MCP clients are closed, resolving "cancel scope" errors and ensuring proper resource termination. It also adds logging callback support throughout the connector architecture.
- Replaces task cancellation with graceful stop events to prevent asyncio cancel scope errors
- Reorders cleanup to stop connection managers before closing client sessions
- Adds logging callback parameter support through connectors
- Improves error handling for MCP protocol errors vs transport errors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mcp_use/task_managers/base.py | Replaces task cancellation with stop event mechanism for graceful shutdown |
| mcp_use/connectors/http.py | Adds MCP protocol error handling and fixes connection manager cleanup call |
| mcp_use/connectors/base.py | Reorders cleanup sequence to prevent cancel scope mismatches |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: lorenss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes Docker containers and subprocesses not terminating when closing multiple MCP-use clients. Also adds logging callback support.
Implementation Details
Fixed asyncio cancel scope error during cleanup
_stop_eventinstead of task cancellationAdded logging callback support
LoggingFnTthrough all connectors and client initializationExample
Testing
Backwards Compatibility
Fully backwards compatible - all changes are internal or optional parameters.