fix(lint-and-review-docs): don't fail on PRs only containing new files#43282
Open
fix(lint-and-review-docs): don't fail on PRs only containing new files#43282
Conversation
4eff861 to
414f344
Compare
cb90693 to
a2be0c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This job errors out when only new markdown files are added: https://github.com/mdn/content/actions/runs/22491270321/job/65153850227?pr=43109
Reproduced in this PR with this commit
a2be0c8and this workflow run: https://github.com/mdn/content/actions/runs/22496878636/job/65173642704?pr=43282And fixed with this commit
255e861and this workflow run: https://github.com/mdn/content/actions/runs/22496961201/job/65173929031?pr=43282(The
pull_request_targetruns of this workflow failed on both commits, as it runs the workflow frommain, which still has the bug.)Also fixes a mixup between HEAD/BASE in a comment and github commit message, and ensures the
pull_requesttarget runs of the workflow actually behave in the same way as thepull_request_targetones do.