Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(lint-and-review-docs): don't fail on PRs only containing new files#43282

Open
LeoMcA wants to merge 5 commits intomainfrom
lint-and-review-unstaged
Open

fix(lint-and-review-docs): don't fail on PRs only containing new files#43282
LeoMcA wants to merge 5 commits intomainfrom
lint-and-review-unstaged

Conversation

@LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Feb 27, 2026

This job errors out when only new markdown files are added: https://github.com/mdn/content/actions/runs/22491270321/job/65153850227?pr=43109

Reproduced in this PR with this commit a2be0c8 and this workflow run: https://github.com/mdn/content/actions/runs/22496878636/job/65173642704?pr=43282

And fixed with this commit 255e861 and this workflow run: https://github.com/mdn/content/actions/runs/22496961201/job/65173929031?pr=43282

(The pull_request_target runs of this workflow failed on both commits, as it runs the workflow from main, which still has the bug.)

Also fixes a mixup between HEAD/BASE in a comment and github commit message, and ensures the pull_request target runs of the workflow actually behave in the same way as the pull_request_target ones do.

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project labels Feb 27, 2026
@LeoMcA LeoMcA force-pushed the lint-and-review-unstaged branch from 4eff861 to 414f344 Compare February 27, 2026 15:38
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Feb 27, 2026
@LeoMcA LeoMcA force-pushed the lint-and-review-unstaged branch from cb90693 to a2be0c8 Compare February 27, 2026 17:34
@LeoMcA LeoMcA changed the title wip: test if untracked file breaks lint-and-review-docs workflow fix(lint-and-review-docs): don't fail on PRs only containing new files Feb 27, 2026
@LeoMcA LeoMcA marked this pull request as ready for review February 27, 2026 17:46
@LeoMcA LeoMcA requested a review from a team as a code owner February 27, 2026 17:46
@LeoMcA LeoMcA requested a review from globau February 27, 2026 17:48
Copy link

@globau globau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants