Fix sanitizer usage in setHTMLUnsafe examples#43307
Open
Conversation
Contributor
|
Preview URLs (1 page) |
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
@dibery I've tested the code examples in question, and they seem to work for me. They are only snippets, and to get the example to work, you'd also have to create the someElement and untrustedString references.
But the bit you've changed doesn't look wrong in the first place.
What did you find that didn't work about the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix sanitizer usage in
setHTMLUnsafeexamples. Current example doesn't work.Motivation
Fix usage example so future readers won't have to spend time figuring out why the example code doesn't work.
Additional details
There are problems in these examples in the following sections:
https://developer.mozilla.org/en-US/docs/Web/API/HTML_Sanitizer_API#sanitization_methods
https://developer.mozilla.org/en-US/docs/Web/API/HTML_Sanitizer_API#using_an_allow_sanitizer_configuration
Related issues and pull requests
No.