prometheus and grafana dashboards implemented #2657
Conversation
|
@irevoire Fixed the issues in the review. |
|
Hey, I'm off today I'll look into it tomorrow! |
There was a problem hiding this comment.
Hey, @pavo-tusker thank you for your contribution it’s awesome, I want to see what the rest of the @meilisearch/core-team thinks of it before merging it.
But overall great contribution, thanks!
|
Ok @pavo-tusker, so after chatting with the team we would really like to integrate your change but with the option to disable it. |
|
Hey, just so you know, clippy was updated last weekend thus you'll need to rebase on main to make the CI pass again. |
Hey, @irevoire Just added the " --enable-metrics-route " option as per the above discussions. By default, metrics will be disabled. passing "--enable-metrics-route" arg will enable /metrics route and Req/Res metrics. Removed wrap_fn and changed it as a conditional wrap middleware. and what do I need to do on Clippy? can you give some more details about this? |
There was a problem hiding this comment.
Hey @pavo-tusker we're almost there!
After accepting my last change you will need to rebase on main (there should be no conflict from what I see) and I’ll be able to merge your change!
It should be something like that depending on your workflow.
git checkout main
git pull upstream/main
git checkout -
git rebase main
git push -f
|
bors merge EDIT: I was hoping bors would be able to rebase on main alone and make your PR pass the CI, but it looks like it does not. |
2657: prometheus and grafana dashboards implemented r=irevoire a=pavo-tusker Implemented Basic Prometheus Metrics and Grafana Dashboard using this [Prometheus Crate](https://crates.io/crates/prometheus) [#496](https://github.com/meilisearch/product/issues/496)    Co-authored-by: mohandasspat <[email protected]> Co-authored-by: Pavo-Tusker <[email protected]>
|
Build failed: |
Co-authored-by: Tamo <[email protected]>
Co-authored-by: Tamo <[email protected]>
9b37554 to
947fb5c
Compare
Co-authored-by: Tamo <[email protected]>
Co-authored-by: Tamo <[email protected]>
2657: prometheus and grafana dashboards implemented r=irevoire a=pavo-tusker Implemented Basic Prometheus Metrics and Grafana Dashboard using this [Prometheus Crate](https://crates.io/crates/prometheus) [#496](https://github.com/meilisearch/product/issues/496)    Co-authored-by: mohandasspat <[email protected]> Co-authored-by: Pavo-Tusker <[email protected]> Co-authored-by: Tamo <[email protected]>
|
Build failed: |
…sker/meilisearch into metrics/prometheus-setup
Again there is an issue with clippy :( on new bors merged code. |
|
Hey @pavo-tusker, finally, we decided we wanted to take more time to refine the feature, thus for the next release (happening today), we're going to move the metrics behind a feature flag (which requires you to build your own meilisearch binary in order to use it). For the next weeks, we’re going to heavily use it and see what other information we can provide, and if, in the end, we are satisfied with the outcome, we’ll probably make it official for the v1.0 (in 4 months) 🎉 I would love to hear your use case, though; why did you feel the need to implement this route, and is it ok for you to recompile meilisearch from scratch in the meantime? |
Sure, 🫡. I was exploring meilisearch for our needs, and observability is something I felt helped understand the queries we did, so I added the same and thought I would make a pull request to contribute. Using as a binary now. |
Implemented Basic Prometheus Metrics and Grafana Dashboard using this Prometheus Crate #496
