Allow wildcards at the end of index names for API Keys and Tenant tokens #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f93b288 to
d7ec9aa
Compare
d7ec9aa to
184b8af
Compare
eb67ecf to
d563ed8
Compare
77a8231 to
c690c4f
Compare
Kerollmops
commented
Feb 9, 2023
|
Hey @ManyTheFish and @irevoire, Could you review this PR, please? It adds the possibility to specify an API Key and a Tenant Token with a pattern that can optionally end with a |
Uffizzi Preview Environment Deploying☁️ https://app.uffizzi.com/github.com/meilisearch/meilisearch/pull/3174 ⚙️ Updating now by workflow run 4165988804. The meilisearch preview environment contains a web terminal from where you can run the Web Terminal Endpoint : |
irevoire
previously approved these changes
Feb 9, 2023
ManyTheFish
previously requested changes
Feb 9, 2023
Co-authored-by: Many the fish <[email protected]>
irevoire
previously approved these changes
Feb 13, 2023
irevoire
approved these changes
Feb 14, 2023
Fixed, we use the InvalidIndexUid code
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the wildcards at the end of the index names when identifying indexes in the API Keys and tenant tokens. It fixes #2788 and fixes #2908. This PR is based on @akhildevelops' work.
Note that when a tenant token filter is chosen to restrict a search, it is always the most restrictive pattern that is chosen. If we have an index pattern prod* that defines filter1 and p* that defines filter2, the engine will choose filter1 over filter2 as it is defined for a most restrictive pattern, prod*. This restrictiveness is defined by 1. is it exact, without * 2. the length of the pattern.
It is a continuation of work that has already started and should close #2869.