Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixup dumps-destination -> dump-directory section header in help link #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fixup dumps-destination -> dump-directory section header in help link #3199

merged 1 commit into from
Feb 6, 2023

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Dec 6, 2022

Pull Request

Related issue

See meilisearch/product#560 (reply in thread)

What does this PR do?

  • change link in help message to the future new section header #dump-directory

@dureuill dureuill added the skip changelog The PR will not appear in the release changelogs label Dec 6, 2022
@dureuill dureuill added this to the v1.0.0 milestone Dec 6, 2022
irevoire
irevoire reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see in the documentation, it's still dumps-destination.
Should we wait before merging?

@dureuill
Copy link
Contributor Author

dureuill commented Dec 6, 2022

Yes, that was my question too (sorry should have repeated it here).

I don't know what the process is for changing documentation-related links that appear in the meilisearch repo, usually

@curquiza
Copy link
Member

curquiza commented Dec 6, 2022 •
edited
Loading

Hum, you are right, the documentation recommends using the config.toml on main, see https://docs.meilisearch.com/learn/configuration/instance_options.html#configuration-file
So we need to change this once v1 is released on the documentation side

@curquiza
Copy link
Member

curquiza commented Dec 6, 2022 •
edited
Loading

I've added "merge this PR once documentation for v1 is deployed" to my TODO, be sure I will not forget it 😉

@irevoire irevoire marked this pull request as draft December 6, 2022 15:47
@irevoire
Copy link
Contributor

irevoire commented Dec 6, 2022

Putting this as a draft so we don't merge it by error

@dureuill dureuill mentioned this pull request Jan 3, 2023
Closed
3 tasks
@dureuill dureuill force-pushed the dumps_destination_terminology branch from 0a53c7c to 1cce613 Compare January 9, 2023 12:33
@dureuill
Copy link
Contributor Author

dureuill commented Jan 9, 2023

Rebased on main to integrate the other changes to the config file (removal of size options, merge of snapshot scheduling options, removal of --disable-auto-batching)

@curquiza curquiza marked this pull request as ready for review February 6, 2023 10:06
curquiza
curquiza approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0 is released so let's merge this

@curquiza
Copy link
Member

curquiza commented Feb 6, 2023

bors merge

bors bot added a commit that referenced this pull request Feb 6, 2023
@bors @dureuill
Merge #3199
b4b5aa5 
3199: Fixup dumps-destination -> dump-directory section header in help link r=curquiza a=dureuill

# Pull Request

## Related issue
See meilisearch/product#560 (reply in thread)

## What does this PR do?
- change link in help message to the future new section header #dump-directory

Co-authored-by: Louis Dureuil <[email protected]>
@curquiza
Copy link
Member

curquiza commented Feb 6, 2023

bors merge-

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Canceled.

@curquiza
Copy link
Member

curquiza commented Feb 6, 2023

Waiting for docs deployment before 😅 my bad!

@curquiza curquiza modified the milestones: v1.0.0, v1.1.0 Feb 6, 2023
@curquiza
Copy link
Member

curquiza commented Feb 6, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build succeeded:

@bors bors bot merged commit 0b60928 into main Feb 6, 2023
@bors bors bot deleted the dumps_destination_terminology branch February 6, 2023 18:32
@meili-bot meili-bot added the v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03 label Apr 6, 2023
@irevoire irevoire added the version upgrade Anything related to the way we update a meilisearch instance label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

+1 more reviewer

@irevoire irevoire irevoire left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip changelog The PR will not appear in the release changelogs v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03 version upgrade Anything related to the way we update a meilisearch instance
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dureuill @curquiza @irevoire @meili-bot