Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix cargo flaky #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix cargo flaky #3348

merged 1 commit into from
Jan 18, 2023

Conversation

irevoire
Copy link
Contributor

@irevoire irevoire commented Jan 16, 2023 •
edited by curquiza
Loading

Related to #3273 but does not fix completely

Ideally, we should revert this commit and fix cargo-flaky directly to ensure we never forget to add a sub-crate to the CI.

Here is an example of the CI running (and thus working); https://github.com/meilisearch/meilisearch/actions/runs/3932783699/jobs/6725755801

@irevoire irevoire added maintenance Issue about maintenance (CI, tests, refacto...) skip changelog The PR will not appear in the release changelogs labels Jan 16, 2023
@curquiza curquiza added this to the v1.1.0 milestone Jan 16, 2023
@irevoire irevoire marked this pull request as ready for review January 16, 2023 18:30
@irevoire irevoire requested a review from curquiza January 16, 2023 18:31
curquiza
curquiza previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @irevoire 🙏

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

bors cancel

@curquiza
Copy link
Member

bors r-

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Canceled.

bors bot added a commit that referenced this pull request Jan 17, 2023
@bors @irevoire
Merge #3348
a002ea3 
3348: fix cargo flaky r=curquiza a=irevoire

Partially fix #3273

Ideally, we should revert this commit and fix cargo-flaky directly to ensure we never forget to add a sub-crate to the CI.

-----

Here is an example of the CI running (and thus working); https://github.com/meilisearch/meilisearch/actions/runs/3932783699/jobs/6725755801

Co-authored-by: Tamo <[email protected]>
@curquiza
Copy link
Member

@irevoire can you make this PR merge into main, and not release-v1.0.0. It is not a hotfix for v1.0.0.
Flaky tests only run on main

@curquiza curquiza dismissed their stale review January 17, 2023 08:53

Not merged into the right branch

@irevoire irevoire changed the base branch from release-v1.0.0 to main January 17, 2023 10:03
@irevoire irevoire requested a review from curquiza January 17, 2023 10:04
curquiza
curquiza approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfectooooooo

bors merge

@curquiza curquiza added bug and removed skip changelog The PR will not appear in the release changelogs labels Jan 17, 2023
@irevoire
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 18, 2023

Build succeeded:

@bors bors bot merged commit 1af3089 into main Jan 18, 2023
@bors bors bot deleted the fix-cargo-flaky branch January 18, 2023 15:21
@meili-bot meili-bot added the v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03 label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@irevoire @curquiza @meili-bot