Enhance facet string normalization #3372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is that true, though? The end of your message tells me these words would be sorted like that, but if I understood correctly, the first part they're actually going to be sorted like that; ACTUALLY: I just reread your message, and that's exactly what you said, I just missed the important Nice improvement whatsoever 👍 |
|
thanks @Kerollmops and @irevoire, bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Use compatibility decomposition normalizer in facet string extraction in order to have a more human friendly sort order.
Now, é (U+00E9) is converted to e (U+0065) + ◌́ (U+0301). This way any word starting with an accented/diacritized version of a character is put just after the words starting with the unaccented version of the character.
Related issue
Fixes #3260