Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add new search parameters highlightPreTag, highlightPostTag and cropMarker #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2022
Merged

Add new search parameters highlightPreTag, highlightPostTag and cropMarker #445

merged 2 commits into from
Apr 25, 2022

Conversation

alallema
Copy link
Contributor

As per meilisearch/meilisearch#2214 new search parameters are introduced:

  • highlightPreTag
  • highlightPostTag
  • cropMarker

@alallema alallema mentioned this pull request Apr 20, 2022
Merged
@alallema alallema changed the base branch from main to bump-meilisearch-v0.27.0 April 20, 2022 12:36
@alallema
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 20, 2022
@bors
Try #445:
9ccdc26
@bors
Copy link
Contributor

bors bot commented Apr 20, 2022

try

Build failed:

@alallema alallema added the enhancement New feature or request label Apr 21, 2022
@bidoubiwa
Copy link
Contributor

Weird that it doesnt test against pre-release. Sometimes it happens that you need to make an empty commit to trigger it.

@curquiza
Copy link
Member

curquiza commented Apr 21, 2022 •
edited
Loading

Weird that it doesnt test against pre-release. Sometimes it happens that you need to make an empty commit to trigger it.

It happens when you open a PR on the wrong base. When changing the base, the CI events are not re-triggered. So originally GitHub thinks "oh this PR is pointing to main so I don't need to trigger the pre-release test workflow". If you change the base, GitHub will not re-trigger the CI again until the next commit...

Capture d’écran 2022-04-21 à 18 35 50

@alallema
Copy link
Contributor Author

It happens when you open a PR on the wrong base. When changing the base, the CI events are not re-triggered. So originally GitHub thinks "oh this PR is pointing to main so I don't need to trigger the pre-release test workflow". If you change the base, GitHub will not re-trigger the CI again until the next commit...

I knew it! Thanks for the empty commit tips!!!

bidoubiwa
bidoubiwa approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

tests/index/test_index_search_meilisearch.py
'limit': 1,
'attributesToCrop': ['overview'],
'cropLength': 10,
'cropMarker': '(ꈍᴗꈍ)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ꈍᴗꈍ)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stole your emojis 😍

@alallema alallema merged commit ffd9664 into bump-meilisearch-v0.27.0 Apr 25, 2022
@alallema alallema deleted the cropping_highlighting branch April 25, 2022 11:19
@alallema alallema mentioned this pull request May 5, 2022
Merged
bors bot added a commit that referenced this pull request May 9, 2022
@bors @meili-bot
@brunoocasali @alallema
Merge #439
4f0cc2a 
439: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #440 
- #443 
- #444 
- #445
- #450 


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
bors bot added a commit that referenced this pull request May 9, 2022
@bors @alallema
Merge #456
2e1c284 
456: Update version for the next release (v0.18.3) r=curquiza a=alallema

This version makes this package compatible with Meilisearch v0.27.0🎉 
Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.27.0) for more information about the changes.

## 🚀 Enhancements

- Add new methods for the new typo tolerance settings #443 `@alallema`
`index.get_typo_tolerance()`
`index.update_typo_tolerance(params)`
`index.reset_typo_tolerance()`
- Ensure nested field support #444 `@alallema`
- Add new search parameters highlightPreTag, highlightPostTag and cropMarker #445 `@alallema`


Co-authored-by: alallema <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alallema @bidoubiwa @curquiza