Add task cancel API for v0.30.0 #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acb9cc5 to
3ead4e1
Compare
e5fd493 to
6dd53c9
Compare
bidoubiwa
reviewed
Nov 16, 2022
cba795a to
57f3953
Compare
57f3953 to
3f170d1
Compare
bidoubiwa
reviewed
Nov 16, 2022
f13edf8 to
fd481df
Compare
bidoubiwa
suggested changes
Nov 16, 2022
dee4333 to
c54dbf0
Compare
fd481df to
b8a1aa1
Compare
835f9d6 to
b9af137
Compare
bidoubiwa
reviewed
Nov 17, 2022
b9af137 to
df03c15
Compare
df03c15 to
010eb99
Compare
sanders41
reviewed
Nov 20, 2022
Co-authored-by: Paul Sanders <[email protected]>
Co-authored-by: Paul Sanders <[email protected]>
Co-authored-by: Paul Sanders <[email protected]>
bidoubiwa
suggested changes
Nov 21, 2022
| @@ -11,7 +11,8 @@ class Task(CamelBase): | |||
| status: str | |||
| type: str | |||
| details: Dict[str, Any] | |||
There was a problem hiding this comment.
In another PR, this should be changed to Union[Dict[str, Any], None]
714465a to
12569d9
Compare
That would work. There is also another option to keep it a function that would be simpler and require no change in the task module while still making things clear. from meilisearch import task
def get_task(self, uid: int) -> Task:
# ...
task = task.get_task(x) |
sanders41
reviewed
Nov 21, 2022
There was a problem hiding this comment.
This suggestion is because I just ran into this issue updating the async python client. The current cancel task tests assume other tests have already run and generated tasks. On first starting the server, if a cancel task test is run first it will error because no tasks have been created yet. This fixture creates some tasks to prevent that.
Co-authored-by: Paul Sanders <[email protected]>
Co-authored-by: Paul Sanders <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
588: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ - #597 - #595 - #596 - #598 - #603 Co-authored-by: meili-bot <[email protected]> Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
588: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ - #597 - #595 - #596 - #598 - #603 Co-authored-by: meili-bot <[email protected]> Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cancel task API see spec
Enhancement
It is now possible to delete your tasks:
example:
TODO
canceled_byin Task classerrorin Task classcancel_tasks()index_uidis now optionaluid