Object oriented code #662
Object oriented code #662
Conversation
There was a problem hiding this comment.
Thanks, @Azanul, for this PR!
I made a few small comments 😃
Also, I wonder if TaskHandler is really appropriate I think I will prefer to call this class just Task for consistency in the SDK, but it means that we have to rename the class Task(CamelBase): in the models
Class docstring update Co-authored-by: Amélie <[email protected]>
Do you have a name for |
There was a problem hiding this comment.
Thanks, @Azanul for this PR!
Sorry for the delay but I had a hard time deciding on the naming I think for now it's fine let's leave it like that it stays consistent with others' SDK. And if ever we want to change it we will do it in another PR
Thank you again LGTM! 🎉
|
bors merge |
662: Object oriented code r=alallema a=Azanul # Pull Request ## Related issue Fixes #604 ## What does this PR do? - Converts root level functions to class methods ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Azanul <[email protected]> Co-authored-by: Azanul Haque <[email protected]> Co-authored-by: Amélie <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: Response status code: 422
{"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
Hi @sanders41, |
|
bors merge |
693: Update version for the next release (v0.25.0) r=alallema a=alallema ##⚠️ Breaking changes * Update the return type of methods (#676) `@sanders41` ## 🚀 Enhancements * Transform all the `task` methods to a `TaskHandler` class (#662) `@Azanul` Thanks again to `@Azanul,` `@alallema,` `@brunoocasali` and `@sanders41!` 🎉 Co-authored-by: alallema <[email protected]>
Pull Request
Related issue
Fixes #604
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!