Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test_delete_all_tasks updated #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

test_delete_all_tasks updated #663

merged 1 commit into from
Jan 30, 2023

Conversation

Azanul
Copy link
Contributor

@Azanul Azanul commented Jan 24, 2023

Pull Request

Related issue

Fixes #648

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Azanul Azanul marked this pull request as ready for review January 24, 2023 11:48
sanders41
sanders41 requested changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hard one to reproduce because it happens randomly, but with these lines the test will still be flaky.

    assert len(tasks_after["results"]) >= 1
    assert len(tasks_before["results"]) == len(tasks_after["results"])

alallema
alallema reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Azanul
Thanks for this PR! If you read issue #648 the goal of this PR should be to fix the test, not just to rename it. @sanders41 gave you the line that makes the test flaky. You can take an example on the test_delete_tasks_by_uid to inspire you and do the same but instead of uid by filter.

@bors bors bot merged commit ba78ac5 into meilisearch:main Jan 30, 2023
@alallema
Copy link
Contributor

Oopsy ... It Seems there is something wrong with bors it merged this PR at the same time that the other one:
#664
I might revert the other and re-merge it by hand

@alallema
Copy link
Contributor

alallema commented Jan 30, 2023 •
edited
Loading

That was my mistake. I should check better. When you create the second PR #664, you base the branch Azanul:change_details_in_task_class on the first branch [Azanul:flaky-test] instead of creating it from the main branch of Meilisearch.
I revert the commit from this PR and reopened the issue since it is not fixed yet. Feel free to reopen an other PR

@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema left review comments

@sanders41 sanders41 sanders41 requested changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test
3 participants
@Azanul @alallema @sanders41