Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rollback include py.typed in package build #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Rollback include py.typed in package build #679

merged 1 commit into from
Feb 6, 2023

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Feb 6, 2023

Pull Request

Related issue

This PR #636 seems to have broken the deployment of the package on PyPI this PR rollback this commit
Screenshot 2023-02-06 at 15 58 38

@alallema alallema requested a review from brunoocasali February 6, 2023 15:06
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema alallema merged commit 1ecf348 into main Feb 6, 2023
@alallema alallema deleted the patch-636 branch February 6, 2023 15:26
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Feb 6, 2023
@sanders41
Copy link
Collaborator

include must be specific to poetry, I didn’t realize that. I’ll have to look up what the setup tools equivalent is.

@alallema
Copy link
Contributor Author

alallema commented Feb 9, 2023

include must be specific to poetry, I didn’t realize that. I’ll have to look up what the setup tools equivalent is.

Yes, I was looking for an equivalent and I thought it was build-backend but it didn't seams to fix the issue.
I found this but haven't had time to check it yet:

[tool.poetry]
# ...
packages = [
    { include = "my_package" },
    { include = "extra_package/**/*.py" },
]

@sanders41
Copy link
Collaborator

It looks like this will still be poetry specific with [tool.poetry]. But if you are wanting to switch from pipenv to poetry you would get no arguments from me 😄

I did a little searching and didn’t find a way to include it in the pyproject.toml using setup tools. This surprises me so I could just not be finding it. What we may need to do is include the py.typed in a MANIFEST.in file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants