Make params required in cancel_task #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
approved these changes
May 24, 2023
There was a problem hiding this comment.
Thanks @sanders41 for raising this issue and fixing it! 🚀
Indeed, for the sake of consistency, it's much better this way
LGTM!
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
I went this direction because I figure most people are using
cancel_tasksfrom theClient. With that I madeTaskHandlermatch what is done inClient. If you think another direction would be better I can make changes.Related issue
Fixes #760
What does this PR do?
parmsrequired incancel_tasksforTaskHandlerPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!