Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Bump Nox#2865

Merged
edgarrmondragon merged 2 commits into
mainfrom
edgarrmondragon/ci/bump-nox
Feb 10, 2025
Merged

chore: Bump Nox#2865
edgarrmondragon merged 2 commits into
mainfrom
edgarrmondragon/ci/bump-nox

Conversation

@edgarrmondragon

@edgarrmondragon edgarrmondragon commented Jan 31, 2025 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Upgrade Nox to 2025.2.9 and use uvx instead of uv tool run.

Build:

  • Update Nox version in noxfile.py and requirements.txt.
  • Use uvx instead of uv tool run in noxfile.py

CI:

  • Add .github/workflows/resources/requirements.txt to the cookiecutter-e2e workflow trigger paths.

📚 Documentation preview 📚: https://meltano-sdk--2865.org.readthedocs.build/en/2865/

@sourcery-ai

sourcery-ai Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer's Guide by Sourcery

This pull request upgrades Nox to version 2025.2.9, replacing the use of 'uv tool run' with the simplified 'uvx' command across various sessions in the noxfile. It also refines dependency management by changing how dependency groups are loaded and updates the CI configuration to trigger E2E tests on changes to a new requirements file.

Flow Diagram for Nox Test Cookiecutter Session Commands (Flow Diagram)

graph TD;
  A[Start Test Session] --> B[Run 'uvx cookiecutter --replay-file <replay_file>']
  B --> C[Build project: run 'uv build']
  C --> D[Run 'uvx twine check dist/*']
  D --> E[Run git commands: init & add]
  E --> F[Run 'uvx pre-commit run --all-files']
  F --> G[End of Session]
Loading

Flow Diagram for Updated CI Workflow Trigger (Flow Diagram)

graph TD;
  A[Detect file changes] --> B{Which files changed?}
  B -- "cookiecutter/**, e2e-tests/**, .github/workflows/cookiecutter-e2e.yml" --> C[Trigger E2E Workflow]
  B -- ".github/workflows/resources/requirements.txt" --> C
  C --> D[Run CI E2E Tests]
Loading

File-Level Changes

Change Details Files
Bump Nox version for improved dependency management
  • Updated 'nox.needs_version' from '>=2024.4.15' to '>=2025.2.9' in the noxfile
  • Updated the Nox version in the requirements file to reflect the latest version
 noxfile.py
.github/workflows/resources/requirements.txt
Switch from 'uv tool run' to 'uvx' command execution
  • Replaced 'uv tool run' with 'uvx' in cookiecutter session for command execution
  • Updated twine and pre-commit commands to use 'uvx'
  • Modified the api_changes session to run 'uvx griffe' with appropriate arguments
 noxfile.py
Refine dependency loading for better configuration
  • Changed dependency group loading by removing an explicit file path from the load_toml call
  • Ensured dependency groups are accessed correctly without specifying 'pyproject.toml'
 noxfile.py
Update CI configuration for cookiecutter E2E tests
  • Modified the cookiecutter E2E workflow to trigger on changes to '.github/workflows/resources/requirements.txt'
 .github/workflows/cookiecutter-e2e.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codspeed-hq

codspeed-hq Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #2865 will not alter performance

Comparing edgarrmondragon/ci/bump-nox (d584a37) with main (61a0b88)

Summary

✅ 7 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch 2 times, most recently from 232bf4f to 40c91a5 Compare January 31, 2025 22:48
@edgarrmondragon edgarrmondragon self-assigned this Jan 31, 2025
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from 40c91a5 to 9ad5fb2 Compare January 31, 2025 22:49
@codecov

codecov Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (61a0b88) to head (d584a37).
Report is 130 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2865   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          62       62           
  Lines        5203     5203           
  Branches      675      675           
=======================================
  Hits         4752     4752           
  Misses        319      319           
  Partials      132      132

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from 9ad5fb2 to e02f669 Compare January 31, 2025 23:30
@edgarrmondragon

edgarrmondragon commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator Author

@sourcery-ai review

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from e02f669 to 4d690e2 Compare February 5, 2025 15:57
@edgarrmondragon
chore: Require uv be used with Nox (#2866)
2548877 
* chore: Require uv be used with Nox

* Use uv more broadly

* Move `UV_CONSTRAINT` to the top

* Remove redundant installation of griffe
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch 3 times, most recently from deeb5ed to 7cb1c18 Compare February 10, 2025 05:18
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/ci/bump-nox branch from 7cb1c18 to d584a37 Compare February 10, 2025 05:19
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 10, 2025 05:23
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner February 10, 2025 05:23
sourcery-ai[bot]
sourcery-ai Bot reviewed Feb 10, 2025
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider updating the pinned versions of pre-commit and twine in .github/workflows/resources/requirements.txt.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@edgarrmondragon edgarrmondragon merged commit 99b726f into main Feb 10, 2025
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/ci/bump-nox branch February 10, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@edgarrmondragon edgarrmondragon

Labels

CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edgarrmondragon